Add an "Automatic module name" entry to the manifest#27
Open
haumacher wants to merge 6 commits intotking:masterfrom
Open
Add an "Automatic module name" entry to the manifest#27haumacher wants to merge 6 commits intotking:masterfrom
haumacher wants to merge 6 commits intotking:masterfrom
Conversation
This is necessary to make the library usable from modular Java 17 projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A modular Java 17 project requires to declare dependencies to other modules. When a dependency is not modular, it must at least declare a module name in its manifest to be usable:
From this PR, only e8ffcdd is technically necessary, but I needed the other changes to be able to build the project with a recent JDK.