minor fixes #22
Open
minor fixes #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the called script is a symlink, resolve said symlink to find the proper install path. Requires readlink(1).
grep matches the full keyword, ending with ':', to avoid false positives from comments and/or matches frm other keywords.
ernstki
added a commit
to ernstki/mad
that referenced
this pull request
Jul 4, 2020
See: https://patch-diff.githubusercontent.com/raw/tj/mad/pull/22 - if symlinked, 'mad' now discovers its config based on a relative path to the link target - match keywords with an anchor at the beginning of the string - link highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The first patch is allows the script to resolve it's proper install path, in case it has been symlinked to somewhere else.
The second one is minor tinkering with the config file parsing to allow grep to match the only the exact keyword, at the start of the line thus preventing false positives from comment lines, in case of a future new keyword contain the current one.