Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Apr 1, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

bdraco and others added 4 commits April 1, 2025 10:47
…10672)

## What do these changes do?

If `CIMultiDict` is passed in we need to make a copy to avoid mutating
it. In some cases we used to copy these twice which was fixed in #10045
but for this case that was the only copy being made and the source of
this regression.

fixes #10670
<!--pre-commit.ci start-->
updates:
- [github.com/PyCQA/flake8: 7.1.2 →
7.2.0](PyCQA/flake8@7.1.2...7.2.0)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
Bumps [multidict](https://github.com/aio-libs/multidict) from 6.2.0 to
6.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/aio-libs/multidict/releases">multidict's
releases</a>.</em></p>
<blockquote>
<h2>6.3.0</h2>
<h2>Bug fixes</h2>
<ul>
<li>
<p>Set operations for <code>KeysView</code> and <code>ItemsView</code>
of case-insensitive multidicts and their proxies are processed in
case-insensitive manner.</p>
<p><em>Related issues and pull requests on GitHub:</em>
<a
href="https://redirect.github.com/aio-libs/multidict/issues/965">#965</a>.</p>
</li>
<li>
<p>Rewrote :class:<code>multidict.CIMultiDict</code> and it proxy to
always return
:class:<code>multidict.istr</code> keys. <code>istr</code> is derived
from :class:<code>str</code>,
thus the change is backward compatible.</p>
<p>The performance boost is about 15% for some operations for C
Extension,
pure Python implementation have got a visible (15% - 230%) speedup as
well.</p>
<p><em>Related issues and pull requests on GitHub:</em>
<a
href="https://redirect.github.com/aio-libs/multidict/issues/1097">#1097</a>.</p>
</li>
<li>
<p>Fixed a crash when extending a multidict from multidict proxy if C
Extensions were used.</p>
<p><em>Related issues and pull requests on GitHub:</em>
<a
href="https://redirect.github.com/aio-libs/multidict/issues/1100">#1100</a>.</p>
</li>
</ul>
<h2>Features</h2>
<ul>
<li>
<p>Implemented a custom parser for <code>METH_FASTCALL |
METH_KEYWORDS</code> protocol
-- by :user:<code>asvetlov</code>.</p>
<p>The patch re-enables fast call protocol in the
:py:mod:<code>multidict</code> C Extension.</p>
<p>Speedup is about 25%-30% for the library benchmarks for Python
3.12+.</p>
<p><em>Related issues and pull requests on GitHub:</em>
<a
href="https://redirect.github.com/aio-libs/multidict/issues/1070">#1070</a>.</p>
</li>
<li>
<p>The C-extension no longer pre-allocates a Python exception object in
lookup-related methods of :py:class:<code>~multidict.MultiDict</code>
when the
passed-in <em>key</em> is not found but <em>default</em> value is
provided.</p>
<p>Namely, this affects :py:meth:<code>MultiDict.getone()
&lt;multidict.MultiDict.getone&gt;</code>,
:py:meth:<code>MultiDict.getall()
&lt;multidict.MultiDict.getall&gt;</code>,
:py:meth:<code>MultiDict.get() &lt;multidict.MultiDict.get&gt;</code>,
:py:meth:<code>MultiDict.pop() &lt;multidict.MultiDict.pop&gt;</code>,
:py:meth:<code>MultiDict.popone()
&lt;multidict.MultiDict.popone&gt;</code>, and
:py:meth:<code>MultiDict.popall()
&lt;multidict.MultiDict.popall&gt;</code>.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/aio-libs/multidict/blob/master/CHANGES.rst">multidict's
changelog</a>.</em></p>
<blockquote>
<h1>6.3.0</h1>
<p><em>(2025-03-31)</em></p>
<h2>Bug fixes</h2>
<ul>
<li>
<p>Set operations for <code>KeysView</code> and <code>ItemsView</code>
of case-insensitive multidicts and their proxies are processed in
case-insensitive manner.</p>
<p><em>Related issues and pull requests on GitHub:</em>
:issue:<code>965</code>.</p>
</li>
<li>
<p>Rewrote :class:<code>multidict.CIMultiDict</code> and it proxy to
always return
:class:<code>multidict.istr</code> keys. <code>istr</code> is derived
from :class:<code>str</code>,
thus the change is backward compatible.</p>
<p>The performance boost is about 15% for some operations for C
Extension,
pure Python implementation have got a visible (15% - 230%) speedup as
well.</p>
<p><em>Related issues and pull requests on GitHub:</em>
:issue:<code>1097</code>.</p>
</li>
<li>
<p>Fixed a crash when extending a multidict from multidict proxy if C
Extensions were used.</p>
<p><em>Related issues and pull requests on GitHub:</em>
:issue:<code>1100</code>.</p>
</li>
</ul>
<h2>Features</h2>
<ul>
<li>
<p>Implemented a custom parser for <code>METH_FASTCALL |
METH_KEYWORDS</code> protocol
-- by :user:<code>asvetlov</code>.</p>
<p>The patch re-enables fast call protocol in the
:py:mod:<code>multidict</code> C Extension.</p>
<p>Speedup is about 25%-30% for the library benchmarks for Python
3.12+.</p>
<p><em>Related issues and pull requests on GitHub:</em>
:issue:<code>1070</code>.</p>
</li>
<li>
<p>The C-extension no longer pre-allocates a Python exception object in
lookup-related methods of :py:class:<code>~multidict.MultiDict</code>
when the
passed-in <em>key</em> is not found but <em>default</em> value is
provided.</p>
<p>Namely, this affects :py:meth:<code>MultiDict.getone()
&lt;multidict.MultiDict.getone&gt;</code>,
:py:meth:<code>MultiDict.getall()
&lt;multidict.MultiDict.getall&gt;</code>, :py:meth:`MultiDict.get()</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aio-libs/multidict/commit/93482a83d2c0b9246992b34b95e4748aaa417151"><code>93482a8</code></a>
Release 6.3.0 (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1109">#1109</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/5d022e9957a5e9ec888adf736fdd563783d92c9b"><code>5d022e9</code></a>
Properly support set operations for case insensitive multidict views (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1038">#1038</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/675c4ae3a8ce52d55e0f62ee7f77fca6442db93a"><code>675c4ae</code></a>
Benchmarks for ItemsView (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1108">#1108</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/b5d9bd1a0d50afc94c892423b1c9782d5ff6ed15"><code>b5d9bd1</code></a>
Add benchmarks for iterating multidict (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1107">#1107</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/1ba64e739de1c41cd51ce2e4ef6f246420a638a9"><code>1ba64e7</code></a>
Run benchmark against all multidict implementations (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1106">#1106</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/389758e0b4ad7c5037b56a156106c7e82ad54201"><code>389758e</code></a>
Use istr as keys in CIMultiDict (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1097">#1097</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/10a97e1340d80a7f22adcd69ffd575345f0d9143"><code>10a97e1</code></a>
Remove the last element by popitem() (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1105">#1105</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/6097b60832b3a9c841f821a41527606bd9dff3bc"><code>6097b60</code></a>
Optimize multidict extending (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1101">#1101</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/20515ba388e903646bb8bffb2f62c8f64e9af443"><code>20515ba</code></a>
Add benchmarks for creating multidict from dict (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1104">#1104</a>)</li>
<li><a
href="https://github.com/aio-libs/multidict/commit/f6b4db155898a71da5e915767b285aa2f1424765"><code>f6b4db1</code></a>
Add benchmarks for updating/extending multidict with kwargs (<a
href="https://redirect.github.com/aio-libs/multidict/issues/1103">#1103</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/aio-libs/multidict/compare/v6.2.0...v6.3.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=multidict&package-manager=pip&previous-version=6.2.0&new-version=6.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Apr 1, 2025
@pull pull bot merged commit 1f7aa7d into tj-python:master Apr 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (3d11b55) to head (1f7aa7d).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         125      125           
  Lines       37439    37445    +6     
  Branches     2076     2075    -1     
=======================================
+ Hits        36957    36963    +6     
  Misses        335      335           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.59% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.25% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.19% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.27% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 97.82% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 97.91% <100.00%> (+0.04%) ⬆️
Py-3.11.9 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 98.36% <100.00%> (-0.01%) ⬇️
Py-3.13.2 98.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 97.67% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.27% <100.00%> (+10.34%) ⬆️
VM-macos 97.36% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.25% <100.00%> (+<0.01%) ⬆️
VM-windows 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants