feat!: removes Node.js 18 as it reached EOL #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for Node.js 18 across the repository by updating workflows and documentation. The changes include:
- Removal of Node.js 18 configurations and Dockerfile entries in build and lint workflows.
- Updates to Docker image build matrix in workflows to only include Node.js 20 and 22.
- Documentation updates in README to reflect that only Node.js 20 and 22 are now supported.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Removed Node.js 18 references from documentation |
| .github/workflows/hadolint.yml | Updated hadolint command to run only on Dockerfiles for Node.js 20 and 22 |
| .github/workflows/dockerimage.yml | Updated matrix to exclude Node.js 18 |
| .github/workflows/buildx.yml | Removed Node.js 18 Dockerfile paths and respective tag configurations |
Files not reviewed (3)
- 18/Dockerfile: Language not supported
- 18/alpine/Dockerfile: Language not supported
- 18/slim/Dockerfile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for Node.js 18 (Hydrogen) across the repository, including related Dockerfiles, workflows, and documentation. The most important changes are grouped below by theme.
Removal of Node.js 18 Support:
.github/workflows/buildx.yml: Removed all configurations for Node.js 18, including its variants (slimandalpine)..github/workflows/dockerimage.yml: Updated the matrix to exclude Node.js 18, leaving only Node.js 20 and 22..github/workflows/hadolint.yml: Adjusted thehadolintcommand to exclude Node.js 18 Dockerfiles.Deletion of Node.js 18 Dockerfiles:
18/Dockerfile: Removed the main Dockerfile for Node.js 18.18/alpine/Dockerfile: Removed the Alpine variant Dockerfile for Node.js 18.18/slim/Dockerfile: Removed the Slim variant Dockerfile for Node.js 18.Documentation Updates:
README.md: Updated the description and included versions to reflect the removal of Node.js 18. Only Node.js 20 and 22 are now supported.