[cp-8.5] Optimize fetch_entries_to function to avoid stucking write too long. (#382)
#383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. (tikv#382) Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot
bot
added
dco-signoff: yes
glorv
approved these changes
Jul 4, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
overvenus
approved these changes
Jul 4, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual CP of #382
Background
PR #370 fixed a panic issue caused by concurrent updates to
Memtablefollowed by reads on stale indexes. However, we observed that this fix introduced performance regressions under concurrent read/write workloads.Issue
When
fetch_entries_toretrieves a large batch of entries from disk, write operations are blocked until the read completes, delayingMemtableupdates and degrading throughput.Solution
This PR optimizes
fetch_entries_toto reduce contention and improve performance under mixed workloads.Results