feat: add prometheus metrics, indefinite run, darwin/arm64 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goodUrls to 1M if running with maxRequests=-1
sergeyberezansky
force-pushed
the
sergey/add-prometheus-metrics
branch
from
9119aaa to
03b580e
Compare
tigrawap
reviewed
Feb 23, 2025
|
|
||
| func (n *nullRequester) request(responses chan *Response, request *Request) { | ||
| responses <- &Response{request, time.Nanosecond, nil} | ||
| responses <- &Response{request, time.Nanosecond * time.Duration(rand.Intn(1000000)), 0, nil} |
Owner
There was a problem hiding this comment.
why ? this might actually impact iops, did you test?
Collaborator
Author
|
This is a null handler for testing only, so lets add it some rand latencies
…On Sun, Feb 23, 2025, 18:35 Anton Bykov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requesters.go
<#7 (comment)>:
> @@ -28,20 +28,20 @@ type sleepRequster struct {
}
func (n *nullRequester) request(responses chan *Response, request *Request) {
- responses <- &Response{request, time.Nanosecond, nil}
+ responses <- &Response{request, time.Nanosecond * time.Duration(rand.Intn(1000000)), 0, nil}
why ? this might actually impact iops, did you test?
—
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP3XPAPPIRKGH4OA5ZE2ZY32RH2EFAVCNFSM6AAAAABXOEO2HKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZVGY3DONJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.