refactor: remove default values from IMU to front LiDAR transform parameters #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters - Remove default values from imu_to_front_* parameters in drs mapping_based_lidar_lidar_calibrator - Remove default values from imu_to_front_* parameters in drs_seyond mapping_based_lidar_lidar_calibrator - These parameters should be explicitly provided when launching the calibrator
- Add drs_seyond module import to calibrators __init__.py - This enables the drs_seyond calibrators to be registered and available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes default values from IMU to front LiDAR transform parameters and adds drs_seyond module import to ensure proper calibration setup.
Changes
imu_to_front_*parameters indrs/mapping_based_lidar_lidar_calibrator.launch.xmlimu_to_front_*parameters indrs_seyond/mapping_based_lidar_lidar_calibrator.launch.xmldrs_seyondmodule import tocalibrators/__init__.pyto enable drs_seyond calibrators registrationRationale
These transform parameters should be explicitly provided when launching the calibrator to ensure correct calibration results. Removing defaults prevents accidental use of incorrect values. The drs_seyond module import is necessary to make the drs_seyond calibrators available in the system.