If you have multiple views on the same url they will be overwritten and ...#14
Open
denyo wants to merge 1 commit intothujohn:masterfrom
denyo:master
Open
If you have multiple views on the same url they will be overwritten and ...#14denyo wants to merge 1 commit intothujohn:masterfrom denyo:master
denyo wants to merge 1 commit intothujohn:masterfrom
denyo:master
Conversation
…nd only the last one will be returned by getAllSitesIds(). That's why restructuring the returned array to either have the id as a key or nesting id and url one layer deeper makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...only the last one will be returned by getAllSitesIds().
That's why restructuring the returned array to either have the id as a key or nesting id and url one layer deeper makes sense.