Open
Conversation
coresdk/src/coresdk/raspi_adc.cpp
Outdated
| void remote_close_adc(const string &name) | ||
| { | ||
| // Find the device in the local map of remotely opened devices | ||
| auto it = remote_adc_devices.find(name); |
There was a problem hiding this comment.
Just a heads-up in remote_close_adc_device, the pointer stored in remote_adc_devices isn’t being freed before erase, which means the allocated _remote_adc_data will leak. You might want to delete it->second; before erasing, or even better switch the map to unique_ptr so cleanup happens automatically.
ayushindapure
left a comment
ayushindapure
left a comment
There was a problem hiding this comment.
Minor: redundant \n in logs, and please confirm _get_ads7830_pin_address correctly matches datasheet channel addresses.
Otherwise the structure, logging, and test integration look really good.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added the ADC functions defined to the Remote area of SplashKit where this can then be tested and used converting all of them to Remote GPIO friendly functions.
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist