Add Unit tests for the hsb_color function AND modified the color.cpp file#128
Open
Broccoli811 wants to merge 6 commits intothoth-tech:mainfrom
Open
Add Unit tests for the hsb_color function AND modified the color.cpp file#128Broccoli811 wants to merge 6 commits intothoth-tech:mainfrom
Broccoli811 wants to merge 6 commits intothoth-tech:mainfrom
Conversation
…st file to include tests outside the valid range
…cpp from the algorithm library
… more consistent; add alpha checks in hsb_color unit tests
Broccoli811
commented
Aug 31, 2025
Author
Broccoli811
left a comment
There was a problem hiding this comment.
This is a copy of the a diffrent pull request because I have messed up on the previous pull request where it was merging from my "main" branch instead of the correct branch
monicavtasmin
approved these changes
Dec 6, 2025
monicavtasmin
left a comment
There was a problem hiding this comment.
correct branch has been swapped. approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal was to implement new test cases for a function called hsb_color from the color.cpp file to the unit_test_color.cpp file.
To extend this task; I modified the color documentation file for logging and clamping
The Test case is named: "hsb_color converts HSB to RGB correctly". The associated test tag is "hsb_color"
Type of change
How Has This Been Tested?
I have tested this using the documentation as a guide. CMake operations were used to test if certain colors were a certain correct value.
Also added a test for out-of-bounds values
Testing Checklist
Checklist