Move the login system into its own seperate library#111
Open
zwwwenwei wants to merge 12 commits intothoth-tech:mainfrom
Open
Move the login system into its own seperate library#111zwwwenwei wants to merge 12 commits intothoth-tech:mainfrom
zwwwenwei wants to merge 12 commits intothoth-tech:mainfrom
Conversation
With a nested class called Authentication, I've made a new module called LoginLibrary. The SSO login as well as the standard login logic are both contained in the Authentication class. Your AuthenticationController can use the library's methods rather than implementing the login logic yourself once the login system has been moved to the library.
Installed and present in your project's Gemfile is the login_library gem. Depending on how your login library is implemented, modify the code as necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement the feature in authenticationcontroller class and users_controller class