migration of units/states/index/index.coffee#445
migration of units/states/index/index.coffee#445JeffySam wants to merge 3 commits intothoth-tech:9.xfrom
Conversation
rammakablecode
left a comment
There was a problem hiding this comment.
npm ci and npm build passed when I tested, Child components required to complete migration.. so far all good on the partial migration
|
Hi Jeffy, unknown,FATAL: \nActionController::RoutingError (No route matches [GET] "/api/auth/signout_url"):\n I'm not entirely sure which part of the change is responsible but I don't have this error switching back to 9.x. |
|
Hi @kacieje Thanks for checking. Yes — this work is intended to run against 9.x. |
|
Hi Jeffy - to be clear, your changes don't run correctly, rails fails. This does not happen with the current 9.x branch, only with the code from your PR. |
|
@kacieje so how can i make it running? can i please get some help.. |
Description
This PR migrates the
units/indexparent state from AngularJS to Angular and removes the legacy CoffeeScript implementation.The Angular version preserves the existing behaviour of the parent state, including unit loading, role resolution, global view setup, and routing. No functional changes are intended as part of this migration.
This change establishes a clean Angular parent state for all
units/*child routes and removes the remaining AngularJS entry points for the units index state.Type of change
How Has This Been Tested?
The changes were tested locally to ensure the Angular parent state behaves equivalently to the legacy implementation.
Testing performed:
/units/:unitIdusing valid and invalid unit IDsTesting Checklist:
Checklist:
Author: Jeffy Sam