refactor: fixed states import for errors and deleted stale files#439
Open
mannat2634 wants to merge 1 commit intothoth-tech:9.xfrom
Open
refactor: fixed states import for errors and deleted stale files#439mannat2634 wants to merge 1 commit intothoth-tech:9.xfrom
mannat2634 wants to merge 1 commit intothoth-tech:9.xfrom
Conversation
pranjalkat
reviewed
Jan 20, 2026
| 'doubtfire.config', | ||
| 'doubtfire.common', | ||
| 'doubtfire.errors', | ||
| 'doubtfire.errors.states', |
There was a problem hiding this comment.
good, Fixing the imports and removing unused files
|
Fixing the error state imports and removing the stale files makes sense, especially given the issues around unauthorized and timeout states during navigation. The changes feel focused and tidy, and they fit well with the broader Angular migration work. I don’t see anything concerning here. Looks safe to merge. |
YG-GOV
approved these changes
Jan 22, 2026
YG-GOV
left a comment
There was a problem hiding this comment.
looks good to me after the changes have been made, should be good to merge now.
BrianDangDev
approved these changes
Jan 27, 2026
BrianDangDev
left a comment
There was a problem hiding this comment.
Hi Mannat, good work. you can now open a PR to upstream
|
Remember to update the planner board as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors error module imports by correcting the
errors.statesimport and removing migrated/stale error files. This ensures unauthorised and timeout states load correctly after the errors migration and prevents module resolution errors.Fixes # (issue)
Type of change
How Has This Been Tested?
Manual testing was performed locally to verify unauthorised access handling and session timeout behaviour after the errors migration.
Test Steps
Prerequisites
http://localhost:4200Test 1: Unauthorised Access (Role-Based)
/#/admin/institution-settings/unauthoriseddoubtfire.errorsor state loadingTest 3: Timeout State
/#/timeoutTesting Checklist:
Checklist: