Conversation
|
Quick update on the PR I have started the code review and currently the branch is being merged into development causing the 223 commits your branch is ahead trying to merge into the development branch. Can you update the PR to merge into the 9.0x branch? |
|
I've updated the base branch to 9.x. Now it doesn't have the commits from 3 years ago. Its all fixed now. Thank You clarifying this. |
|
I've loaded and tested the change so far, looks like the old component is not yet unhooked from doubtfire-angularjs.module.ts and directives.coffee (this is the last component in directives.coffee so it may be possible to delete it and remove its reference from angular as well) as attached in the screenshots, you'll need to remove these lines and test some more to see if the app will build correctly. It will also need the description and how has this been tested sections of the Pull Request filled out as well as these are still filled with the template text. Testing screenshots will need to be a bit more detailed showing the steps to access the section and what was done to test that the components still work. |
Triet-coder
left a comment
There was a problem hiding this comment.
Looks good — unit-dates-selector migration works smoothly. Rollover page loads, teaching-period dropdown + dates bind correctly, and Create stays disabled until valid (tested in latest Safari). Tiny nits: null-check @input() unit, add a test for “no teaching periods”, and maybe debounce/disable while loading.




Any italic text should be deleted from the final Pull Request text, including this line
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Testing Checklist:
Checklist: