Feature: add the ability to mark unit as complete and skill summary component in refactor codebase#396
Conversation
SahiruWithanage
left a comment
There was a problem hiding this comment.
Great job on this PR, the components look really solid. I pulled the branch down and got it running locally. The frontend side, which is this PR (#396) works nicely on top of the stable 9.x backend, but when I switched the backend to PR #71 as suggested, the project failed to run properly, so something seems off there and might need a closer look to confirm if it’s linked to this PR. With the frontend though, everything behaved as expected: I tested with elective units, added them into the trimester, marked them complete (which correctly locks them in place) and the Skills Summary dialog shows completed vs in-progress units as intended. The only UX suggestion I’d make is to surface the Skills Summary in a more direct way. Right now it’s tucked behind the three-dot menu on each unit even though it shows the same info regardless, so having a single dedicated entry point in the UI could make it easier to discover and use. Overall, Great job!
|
Everything on the frontend side worked smoothly for me as well. The flow for electives and the Skills Summary behaved exactly as expected. Only note is the backend PR (#71) didn’t run cleanly for me either, so that might need another look. Otherwise, great job! |
Description
This PR introduces two main enhancements to the codebase:
1. Mark Unit as Complete (related to this PR: #386)
2. Skill Summary Component
Fixes # (issue)
Refactor Codebase: #385
Fetch this PR: thoth-tech/doubtfire-api#71
Migrate and use this command (rake db:test_data:create_frontend_data) to populate the database
If required units are not populated, use the elective units instead (make sure you are using admin account)
Type of change
How Has This Been Tested?
Tests Performed
1. Unit Completion Toggle
2. Skill Summary Component
Testing Checklist:
Checklist: