Open
Conversation
Author
Author
SahiruWithanage
approved these changes
Sep 20, 2025
SahiruWithanage
left a comment
There was a problem hiding this comment.
Great work on this PR!
I tested the script and it works perfectly.
What I tested:
- Script execution and path resolution
- Remote updates for all submodules
- Error handling with missing directories
- Works correctly in Linux environment
Overall, this is a solid improvement that will make the setup process much more reliable across different operating systems. Ready to merge!
ibi420
approved these changes
Sep 24, 2025
ibi420
left a comment
There was a problem hiding this comment.
Hello,
I can confirm the implementation supports reliable script execution with proper path resolution, enables remote updating of all submodules, and incorporates robust error handling for scenarios involving missing directories. Functionality has been confirmed in Linux environments.
BrianDangDev
approved these changes
Oct 2, 2025
Author
|
Ready to merge branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
Making some changes to the change_remotes.sh script to correct filepath logic to work on multiple operating systems and to ask both origin and upstream with checks to confirm the remotes have changed.
https://github.com/thoth-tech/doubtfire-deploy/blob/main/CONTRIBUTING.md
Step 3 will now work correctly
Fixes #
change_remotes.sh not working on operating systems other than Mac OS and allows for more flexibility on inputs with checks to ensure that the changes to origin and upstream have been made correctly.
Type of change
How Has This Been Tested?
Ran multiple tests to ensure correct origin and upstream are set as well as potential errors to be caught if some repositories are missing and updating text to reflect those changes.
Checklist
If involving code
Folders and Files Added/Modified
Please list the folders and files added/modified with this pull request.