Open
Conversation
Provide the option to build containers via `docker compose build` for cases where the configuraiton is being changed.
Ensure that dev containers can be versioned. Provide instructions on the process.
Add a dev-container capable of building, testing, and running all required components for the basic application.
- provide redis in the dev container - update bundler to 2.4 - move gems from root user to vscode user
When the database is missing, the dev container will create the database, populate it with students, and simulate sign off.
- ensure database launches - create database when not present - retain zsh history for the project - add docker compose for testing devcontainer - add build script to create devcontainer image - add husky to root project
Ensure that database is created and user can see details.
This should fix issues with this working on Windows.
- clear out database in image - setup student-work and workspace tmp
- add bundle install for api - add npm install for web This ensures that these are updated to match the bundle and package.
Added update to explain launch via Dev Container Daniel Maddern
…uctions docs: contributing-dev-containers
- ensure student work is always vscode - ensure simnulate happens... and doesn't end
fix: force npm install in the vscode task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.