Open
Conversation
ibi420
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
The code is well-structured and follows best practices for associations, validations, and authorisation, providing clear endpoints for organisation management. Database migrations are well-executed, and API serialisation ensures maintainable output. The newly implemented API allows for viewing, creating, updating, and deleting users' organisations. I successfully tested this using Postman and confirmed its proper implementation. Thank you for the opportunity to review your work.
10 tasks
|
LGTM. |
Author
|
Hi @aNebula I have opened a new pr on doubtfire-lms/doubtfire-api with 9.x branch , url- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This change implements a comprehensive organization management system for Ontrack. The feature allows administrators to create and manage organizations, and users can be members of multiple organizations. Users can also set their current active organization, which enables organization-specific views and functionality.
Organization CRUD operations (create, read, update, delete)
User membership management (add/remove members)
Organization switching functionality
User search for adding members
Authorization controls for organization management
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
After creating the migration, you can run it with:
rails db:migrate
Test A
Rails console testing for model relationships
Test B
Can Alternatively test from the backend Using Postman
Checklist:
If you have any questions, please contact @macite or @jakerenzella.