review: Task-ilo-alignment-rater Component Review#603
Open
disururathnayake wants to merge 1 commit intothoth-tech:mainfrom
Open
review: Task-ilo-alignment-rater Component Review#603disururathnayake wants to merge 1 commit intothoth-tech:mainfrom
disururathnayake wants to merge 1 commit intothoth-tech:mainfrom
Conversation
atharv02-git
approved these changes
May 17, 2025
atharv02-git
left a comment
There was a problem hiding this comment.
Hi @disururathnayake, your component review clearly states what the migration is about and also outlines the exact purpose of the component, it's outcomes and interactions.
One thing I would like to suggest you here and that would be try adding before and after screenshots to provide justification to your claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a Component review of frontend migration on OnTrack.
Ontrack Component Review
Team Member Name
Disuru Rathnayake
Student ID: s223987245
Component Name
Task-ilo-alignment-rater
Files in this Component
task-ilo-alignment-rater.coffee
task-ilo-alignment-rater.scss
task-ilo-alignment-rater.tpl.html
Component Purpose
This component is responsible for allowing users to rate how well a task aligns with specific learning outcomes (ILOs). It displays a set of icons representing ratings from 0 to 5. Users can select a rating, view or update a rationale, and optionally delete the alignment entirely.
Component Outcomes and Interactions
Expected Outcome:
The migrated task-ilo-alignment-rater component should function and look exactly the same as the original. This includes:
Component Migration Plan
Migration Steps:
Create new files:
task-ilo-alignment-rater.component.ts
task-ilo-alignment-rater.component.html
task-ilo-alignment-rater.component.scss
Import and declare the component in doubtfire-angular.module.ts.
In doubtfire-angularjs.module.ts, downgrade the Angular component so it can be used by AngularJS.
• Check that the new setup works just like the old one by running the same tests.
• Fix any problems that come up during testing.
Component Review Checklist