Students-list component Review#597
Open
HasinduWelarathne wants to merge 1 commit intothoth-tech:mainfrom
Open
Conversation
|
I have looked at all 3 files located at doubtfire-web/src/app/units/states/students-list/ to ensure that the component review matches the above. Based on the code, I can confirm that purpose for this is to provide an interface that helps instructors to manage student lists effectively, enhancing usability by filtering, sorting and interaction pattens. Good job with the Component Review @HasinduWelarathne Please also note, Version Branch 9.x uses Angular version 18 instead of 17. |
nodogx
approved these changes
May 7, 2025
9 tasks
|
Hi @HasinduWelarathne Component Review Looks good, has covered all the essential steps. Good Work |
Author
|
Thank you very much for the comments, guys! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Component Review:
students-listComponentTeam Member
Hasindu Welarathne | 224009927
Component Name & Files
students-list.coffeestudents-list.tpl.htmlstudents-list.scssComponent Purpose
The
students-listcomponent is responsible for displaying and managing a list of students within a unit.It allows instructors (Convenors, Tutors, Admins, Auditors) to:
Component Outcomes and Interactions
✅ View and filter students dynamically based on user role
✅ Search by student name or email in real time
✅ Sort students by attributes like name, email, or status
✅ Paginate the list of students for easier navigation
✅ Export CSV of the filtered and sorted student list
✅ Navigate to an individual student’s dashboard on selection
✅ Open enrolment modal to add new students
Services and Dependencies
UnitStudentEnrolmentModal➔ Opens modal to enrol a new student
newTaskService➔ Provides
statusClassandstatusTextfor displaying student task/project statusnewUserService➔ Supplies the current user info to filter students (e.g., tutor’s students only)
analyticsService➔ Logs analytics events (e.g., opening enrolment modal)
AngularJS Filters Used:
showStudentsprojectFilterpaginateAndSortVisual References
Original design (before migration):
Component Review Checklist
Notes
This review documents the current state of the
students-listcomponent before migration to Angular 17 and TypeScript. It provides a reference baseline for functionality, UI behavior, and service dependencies.The component will be migrated in a future task following the Doubtfire Web Migration Guide.