Conversation
studioant
suggested changes
Oct 2, 2022
Contributor
studioant
left a comment
studioant
left a comment
There was a problem hiding this comment.
@MohdUmbe
This PR is many commits behind main.
Please stash your changes, pull the most recent changes (merge main into your branch), and pop your stash before reattempting this pull request.
Also, it is not immediately obvious what your changes are. Please apply a description to your PR's to provide reviewers with context. Thanks
Delcari
suggested changes
Oct 3, 2022
Contributor
Delcari
left a comment
Delcari
left a comment
There was a problem hiding this comment.
Correct, although it doesn't seem like your branch is actually behind the main branch your changes unnecessarily remove/revert several recent modifications. To simplify things you could just try create a new branch and introduce your modifications into there, good luck! I would love to see this merged before end 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.