docs: add Units module migration investigation and plan#166
Open
JeffySam wants to merge 10 commits intothoth-tech:mainfrom
Open
docs: add Units module migration investigation and plan#166JeffySam wants to merge 10 commits intothoth-tech:mainfrom
JeffySam wants to merge 10 commits intothoth-tech:mainfrom
Conversation
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SteveDala
approved these changes
Jan 31, 2026
Collaborator
SteveDala
left a comment
There was a problem hiding this comment.
LGTM. The plan to migrate the units module seems cogent and well thought through. Although I'm sure more challenges will arise as a result of the attempt to migrate this module, this represents a good starting point to do so.
Collaborator
|
Hi @JeffySam, in your development environment, please execute Checking formatting...
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/UNITS_MODULE_MIGRATION_INVESTIGATION.md
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/UNITS_MODULE_MIGRATION_PLAN.md
[warn] Code style issues found in 2 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1. |
Author
|
hi @SteveDala i did execute npm run format like u said |
Collaborator
|
@JeffySam please make sure your changes are based on the latest upstream changes to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds documentation describing the current state and planned approach for migrating the Units module from AngularJS (CoffeeScript) to Angular (TypeScript).
The documentation focuses on the migration of the Units state hierarchy, including the legacy state aggregator (
units/states/states.coffee) and its Angular replacement. It captures the current migration status, identifies remaining AngularJS states, and outlines a parent-first migration strategy to safely unblock downstream work.Two documents are included:
This PR is documentation-only and does not modify application code.
Fixes: N/A
Type of change
How Has This Been Tested?
No runtime or build testing was required, as this PR contains documentation only.
Testing Checklist
npm run format(not applicable — no code changes)npm run build(not applicable — no code changes)npm run devand/ornpm run preview, using:Checklist