Load project from URL GET parameter-pradeep#98
Open
pradeepkumara wants to merge 2 commits intothoth-tech:mainfrom
Open
Load project from URL GET parameter-pradeep#98pradeepkumara wants to merge 2 commits intothoth-tech:mainfrom
pradeepkumara wants to merge 2 commits intothoth-tech:mainfrom
Conversation
|
Contributor
|
Hi @pradeepkumara this looks great, and I believe it should implement the functionality as expected. However, there are two points that I think could be considered further:
|
Contributor
|
Overall, it looks good. By the way, one additional point to consider is that some comments seem to have been removed in this update. These comments provide valuable context and might be worth keeping in the code to ensure clarity and maintainability. |
pradeepkumara
commented
Jan 14, 2025
Author
pradeepkumara
left a comment
There was a problem hiding this comment.
Thanks for the helpful feedback! I'll add comments in the code to explain what I've changed and what everything does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
i just changed those files where i need to change all the functions, inside IDEStartup and SplashkitOnline js
Fixes # (issue)
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist