Refactored .sh script to Python#142
Open
liammcknightt wants to merge 1 commit intothoth-tech:mainfrom
Open
Conversation
Contributor
|
Approved. This PR cleanly replaces the Unix-only shell script with a cross-platform Python script, improving Windows compatibility without changing core behaviour. The implementation is clear and well-structured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored buildAndCopy.sh script to Python, have not deleted the original script, have preserved identical build and copy behavior.
Fixes # (issue)
Replaces Unix-only C# install shell script with cross-platform Python implementation to fix Windows compatibility.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested by running the script locally to see it completes as expected without any errors and behaves the same as the original script. Can test by cd to CSharpWasm and running the script via python buildAndCopy.py
Testing Checklist
Not needed.
Checklist