Conversation
sam-stajnko
left a comment
There was a problem hiding this comment.
Hi @Oliver-Quail ,
I have looked at the changes you have made in this PR and I can't see anything that stands out as an issue. I can confirm that the following changes have been made and all changes are performing their intended purpose:
- The documentation in the README has been updated since the user no longer needs to change directory into SplashkitOnline/Browser_IDE/.
- All code referencing the 'external' folder has been modified since the contents of this folder have been moved.
- Both the Python and JS setup scripts no longer download the files SplashKitBackendWASMCPP.js and SplashKitBackendWASMCPP.worker.js. I assume this is because they are now included locally in the runtimes/cxx/bin directory?
I have tested the above changes by building the Splashkit Online project on my own machine and making sure the CPP functionality performs its intended purpose, without crashing or bugs.
I can say with confidence that no build or runtime errors were encountered during the time testing. For this reason, I have no problem approving this PR and moving it to the second round of peer review. Keep up the good work Oliver.
Regards,
Sam Stajnko.
Hi Sam, |
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
This has been tested once completed. Then with a recloning and install with both producing identical correct results. Other languages have tested with changes producing know issues.
Please note when testing you will need to run the following command in addition to the other setup commands
Testing Checklist
Checklist