Fix: Correct Windows batch file syntax for else-if condition#6
Merged
Conversation
…kage The build_release.sh script was not copying the new flash tool files to the release directory. This caused v1.0.5 releases to be missing the Quick Flash Tool files even though they were in the git repository. Now build_release.sh properly copies: - Flash Firmware.bat (Windows launcher) - flash_firmware.ps1 (PowerShell flash script) To the root of the release package, making them immediately available when users extract the release ZIP. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The batch file was using 'else if' which is not valid Windows batch syntax. Changed to nested 'else ( if ... )' structure which is the correct syntax. This fixes the 'or was unexpected at this time' error when running Flash Firmware.bat on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…thod Hide the advanced compile/upload method from casual users by: - Moving Upload Firmware (Windows).bat to tools/ folder - Renaming to Compile Firmware (Windows).bat for clarity - Updating build_release.sh to package accordingly - Restructuring UPLOAD_GUIDE.md to show flash first, compile in "Advanced" section - Updating README.txt to emphasize Flash Firmware.bat as main method This reduces confusion for non-technical field users who should use the simple "Flash Firmware.bat" (10 seconds) instead of the advanced compile method (60+ seconds). Root folder now only shows: - Flash Firmware.bat (main method) - README.txt (quick start) - UPLOAD_GUIDE.md (documentation) Advanced tools in tools/ folder: - Compile Firmware (Windows).bat - upload_firmware.sh - upload_firmware.ps1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Flash Firmware.bat was throwing error: 'or was unexpected at this time'
This is caused by using 'else if' in batch files, which is not valid Windows batch syntax.
Solution
Changed to nested 'else ( if ... )' structure which is the proper Windows batch syntax.
Testing
Flash Firmware.bat now runs without syntax errors.