fix: pass correct httpr version to benchmark script #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change pyproject.toml version to 0.0.0.dev0 (PEP 440 compliant placeholder) - Change Cargo.toml version to 0.0.0 (Cargo semver compatible) - Add comments explaining version is set dynamically from git tags - Add docstring to set_version.py explaining its role in CI - Expand action.yml description with full version logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the benchmark is run and the image is committed, the httpr version displayed was incorrect (showing the placeholder version from pyproject.toml instead of the actual release version).
Changes
--httpr-versionCLI argument tobenchmark/benchmark.pyto allow overriding the httpr version in benchmark outputv0.3.0→0.3.0) and pass it to the benchmark scriptdevas the versionThis ensures the benchmark CSV files and generated image will show the correct httpr version from the tag.