Skip to content

Conversation

@thiyaguk09
Copy link
Owner

@thiyaguk09 thiyaguk09 commented Jan 23, 2026

This PR adds a new code sample and system test demonstrating how to handle Partial Success when listing Cloud Storage buckets.

The returnPartialSuccess feature is critical for building resilient applications. It allows the buckets() method to return successfully even if specific regions are experiencing downtime, providing a list of reachable buckets along with a list of unreachable resource paths.

Changes

  • New Sample: Added storage_list_buckets_partial_success snippet.
  • Logic: Implemented handling for the unreachable() method in BucketIterator.
  • Testing: Added a system test to verify the snippet executes correctly and successfully communicates with the Storage API.

Implementation Notes

  • Assertion Strategy: I have included assertTrue(true) at the end of the system test. This serves as a "completion assertion" to explicitly confirm that the entire snippet executed and returned without throwing an exception, which is particularly useful in system tests where the network is involved.
  • Unreachable Buckets: This is a system test hitting the live API. Under normal conditions, all Google Cloud regions are healthy, meaning the unreachable() array will be empty. Therefore, we do not assert specific "Unreachable" output strings to avoid false negatives. The test instead focuses on verifying the reachable Bucket: output, proving the API connection and the returnPartialSuccess configuration are working correctly.

- Add `list_buckets_partial_success` snippet
- Handle `unreachable()` metadata in the sample
- Add system test to verify snippet execution
@gemini-code-assist
Copy link

Summary of Changes

Hello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new code sample and corresponding system test to illustrate how to effectively manage partial success scenarios when listing Google Cloud Storage buckets. By leveraging the returnPartialSuccess option, applications can now gracefully handle regional outages, ensuring that a list of accessible buckets is returned alongside any unreachable resource paths, thereby enhancing application resilience.

Highlights

  • New Sample for Partial Success: Introduced a new PHP sample, storage_list_buckets_partial_success, demonstrating how to list Cloud Storage buckets while gracefully handling partial success scenarios due to regional downtime.
  • Error Handling Logic: The new sample includes logic to check for and iterate through unreachable bucket locations using the unreachable() method of the BucketIterator, providing resilience against regional outages.
  • System Test Coverage: Added a new system test, testListBucketsPartialSuccess, to verify the correct execution and API communication of the new partial success bucket listing sample.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new code sample and a corresponding system test to demonstrate handling partial success when listing Cloud Storage buckets. The new sample, storage_list_buckets_partial_success, is well-implemented and clearly illustrates the usage of the returnPartialSuccess option. The added system test in storageTest.php validates the basic execution of the new snippet. However, the test includes a redundant assertion that should be removed for better code quality. Apart from that minor point, the changes are solid and effectively address the goal of the PR.

@thiyaguk09 thiyaguk09 closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants