Feat(Storage): Enable full object checksum validation on JSON path

[thiyaguk09]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @thiyaguk09, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the storage client's object upload functionality by implementing comprehensive checksum validation. It ensures that both MD5 and CRC32c hashes are calculated for uploaded data and transmitted via the X-Goog-Hash header, improving data integrity verification. The changes also include logic to prevent redundant hash calculations if checksums are already provided, and new tests to cover these behaviors in both resumable and standard upload scenarios.

Highlights

• Checksum Generation: Both MD5 and CRC32c hashes are now calculated for uploaded objects when validation is enabled, ensuring comprehensive data integrity checks.
• X-Goog-Hash Header: A new X-Goog-Hash header is constructed from the calculated MD5 and CRC32c hashes and included in upload requests to Google Cloud Storage.
• Validation Method Enhancement: The chooseValidationMethod now respects pre-existing x-goog-hash headers, allowing users to provide their own checksums and skipping redundant hash calculations.
• Resumable Upload Testing: A new unit test has been added to verify that the X-Goog-Hash header is correctly applied only to the final chunk of resumable uploads.
• Object Insertion Testing: A new unit test confirms the proper calculation and inclusion of the X-Goog-Hash header during standard object insertion.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables full object checksum validation by sending both CRC32c and MD5 hashes in the x-goog-hash header for uploads. The implementation correctly calculates and adds these hashes. My review highlights a significant performance issue where the data stream is read twice, which could be problematic for large files. I've also included suggestions for minor code cleanup in both the main logic and the tests. The added tests are comprehensive and effectively validate the new functionality.

[gemini-code-assist]

This implementation calculates MD5 and CRC32c hashes by reading the data stream twice (once in Utils::hash and once in crcFromStream). For large objects, this will cause a significant performance overhead due to reading the entire object from storage twice.

Consider refactoring this to calculate both hashes in a single pass over the stream. You could read the stream in chunks, updating both an MD5 context and a CRC32c context in each iteration. This would be much more efficient for large files.