feat(storage): Set CRC32C as the default checksum option

[thiyaguk09]

This PR introduces a change to the insertObject method in the Storage client to set CRC32C as the default checksum for all object uploads.

Why this change is needed
Previously, if a user didn't explicitly specify a validation option, no checksum was calculated or sent to the server. By defaulting to CRC32C, we can ensure a higher level of data integrity during uploads without requiring an extra configuration step from the user. This aligns the library with best practices for interacting with Google Cloud Storage and provides a better out-of-the-box experience.

Implementation details

• The resolveUploadOptions method was updated to check for the presence of the validate key. If it's missing and the user hasn't provided their own checksum in the metadata, validate is now set to crc32c.

• A new test case was added to verify that the library correctly falls back to the default CRC32C validation when no other options are provided.

• An "Undefined array key" error in chooseValidationMethod was also fixed to ensure it handles cases where the validate key is not present.

This change is non-breaking and improves the robustness of the client library.

[thiyaguk09]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to improve data integrity by setting CRC32C as the default checksum for object uploads. The implementation correctly introduces a default, but it appears to use crc32 instead of the intended crc32c. This seems to be a typo that affects both the main logic and the new tests. Correcting this will align the client with Google Cloud Storage best practices and fulfill the goal of the PR.

[thiyaguk09]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request enhances the Storage client by setting a default checksum validation for object uploads. The primary goal is to improve data integrity by ensuring that crc32 checksums are automatically calculated and sent to the server if no other validation method is specified. This change aims to provide a more robust out-of-the-box experience for users interacting with Google Cloud Storage, reducing the need for manual configuration to ensure data consistency during uploads.

Highlights

• Default Checksum: The default checksum option for object uploads in the Storage client's insertObject method has been updated to crc32 when no specific validation is provided.
• Implementation Detail: The resolveUploadOptions method was modified to ensure that if the validate key is missing or not explicitly set, it defaults to 'crc32' for checksum validation.
• Test Coverage: New test cases have been introduced to confirm that the system correctly falls back to crc32 validation when the validate option is null or an empty string.

Changelog

• Storage/src/Connection/Rest.php
  • Modified the resolveUploadOptions method to change the default value of the validate option from true to the string 'crc32'.
• Storage/tests/Unit/Connection/RestTest.php
  • Added new test cases to the validationMethod data provider to verify that when the validate option is null or an empty string, the system correctly defaults to 'crc32' validation.

Activity

• thiyaguk09 initiated a review request using the '/gemini review' command.
• gemini-code-assist[bot] provided a critical review comment on 'Storage/src/Connection/Rest.php', suggesting that 'crc32' should be 'crc32c' to align with the PR description and best practices.
• thiyaguk09 responded to the bot's comment, clarifying that 'crc32' is not a typo.
• gemini-code-assist[bot] provided a medium-priority review comment on 'Storage/tests/Unit/Connection/RestTest.php', suggesting the expected value in a new test case should be 'crc32c' instead of 'crc32'.
• gemini-code-assist[bot] provided another medium-priority review comment on 'Storage/tests/Unit/Connection/RestTest.php', similarly suggesting 'crc32c' for another new test case.
• thiyaguk09 requested a summary using the '/gemini summary' command.