Open
Conversation
alexbeeken
approved these changes
Dec 5, 2019
Contributor
alexbeeken
left a comment
alexbeeken
left a comment
There was a problem hiding this comment.
the only thing I can think is that getChannelURL as a name is a little bit confusing.
Author
|
I believe that is from the default blueprint. (Though admittedly that is a bit out of date) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Ensure there is a human readable title
The titles will be what shows up in the automated changelog for the rest of the company to see.
Ensure there is a description of the work that helps reviewers understand the context.
Tag the PR appropriately
In particular, tag with 'bug' if it's a bug fix, 'enhancement' for any other customer facing code, or 'skip changelog' if it's something that only matters to the tech team (i.e.
weekly-releasebranch PRs should always be tagged 'skip changelog').Tag with "Needs Code Review" when it is ready for code review, and "Needs AC Review" if it is a Sprint item.
Complete any applicable sections below
Related repo links, such as Rails, Ember, addons or gems (if applicable)
Podio link (if applicable)
PRE DEPLOY TASKS
POST DEPLOY TASKS