build: update rquickjs revision based on 0.10 #3900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
rina23q
requested review from
albinsuresh,
didier-wenzek,
jarhodes314 and
reubenmiller
as code owners
rina23q
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
rina23q
commented
Dec 18, 2025
| rquickjs = { git = "https://github.com/thin-edge/rquickjs", rev = "4ed04ac9af3de453dd41ff09fdd1837c7ceb1f1c", default-features = false, features = [ | ||
| # disable bindgen and rely on pre-generated bindings due to problems | ||
| # generating the bindings at build time with clang | ||
| rquickjs = { git = "https://github.com/thin-edge/rquickjs", rev = "7508f0c3c134352f8cd64a4c33cc0c063f3e2ab0", default-features = false, features = [ |
Member
Author
There was a problem hiding this comment.
Instead of revision, we can specify branch name. Maybe it's easier for Yocto eventually, as it needs to patch to this Cargo.toml file to enable the bindgen feature like this.
Suggested change
| rquickjs = { git = "https://github.com/thin-edge/rquickjs", rev = "7508f0c3c134352f8cd64a4c33cc0c063f3e2ab0", default-features = false, features = [ | |
| rquickjs = { git = "https://github.com/thin-edge/rquickjs", branch = "extend-bindings2", default-features = false, features = [ |
Contributor
Robot Results
|
rina23q
requested a deployment
to
Test Pull Request
GitHub Actions
Waiting
rina23q
requested a deployment
to
Test Pull Request
GitHub Actions
Waiting
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
rina23q
force-pushed
the
build/update-rquickjs-dependency
branch
from
28c6025 to
a9b2832
Compare
rina23q
requested a deployment
to
Test Pull Request
GitHub Actions
Waiting
Member
Author
|
We chose the approach in #3896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Instead of enabling the
bindgenfeature ofrquickjs(#3892 & #3896), we can keep pre-generated bindings in our rquickjs fork.The advantage of this approach is, we can avoid making additional dependencies on build tools.
The changes on our fork are bar minimal:
scripts/gen-bindings.shto add our targetsCheck the diff:
Since the latest release of
rquickjsis now 0.10, the new revision is also based on 0.10.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments