Open
Conversation
cyndis
commented
Jul 10, 2015
cyndis
commented
- Removes watchdog.py because it was unused and duplicate code is in system.py
- Use 'with' blocks instead of normal construction because otherwise we cannot guarantee release of resources like fds
- Add VIC/host1x test to drm.py. The test is only run if the currently hardcoded path to the test binary exists.
This test tests the VIC and Host1x submissions.
Execution of __del__ is not guaranteed due to the garbage collector.
Remove the unused linux.watchdog module; it is unused and a duplicate already exists in linux.system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.