Skip to content

Debian support#5

Closed
DexterTheDragon wants to merge 3 commits intothias:masterfrom
DexterTheDragon:debian_support
Closed

Debian support#5
DexterTheDragon wants to merge 3 commits intothias:masterfrom
DexterTheDragon:debian_support

Conversation

@DexterTheDragon
Copy link

I've added in Debian support, keeping it as simple as possible. I also added rspec tests for the existing manifests and the changes I made.

@thias
Copy link
Owner

thias commented Jul 13, 2014

Quick question : According to #4, the packages 'dovecot-imapd' and 'dovecot-pop3d' could also be required. Is that the case, and could they end up missing with your change?

@DexterTheDragon
Copy link
Author

Debian considers both of them as plugins. So if you need IMAP but not pop you can install just imapd.

@thias
Copy link
Owner

thias commented Jul 13, 2014

OK, so with your change, someone who installs dovecot with this puppet module on Debian will not have either of imap nor pop3 support enabled? That would make for quite a useless configuration, for which enabling either or both should be supported by the module, don't you think?

@DexterTheDragon
Copy link
Author

no, it allows you to control the configuration. If you only need imap you can do

class { 'dovecot':
  plugins => [ 'imapd'],
}

If you need both:

class { 'dovecot':
  plugins => [ 'imapd', 'pop3d'],
}

@jshholland
Copy link

What is the status of this pull request? Debian/Ubuntu support is necessary for us, and the diff looks good to me, though perhaps a note about requiring plugins => ['imapd'], in the readme might be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants