Debian support#5
Debian support#5DexterTheDragon wants to merge 3 commits intothias:masterfrom DexterTheDragon:debian_support
Conversation
|
Quick question : According to #4, the packages 'dovecot-imapd' and 'dovecot-pop3d' could also be required. Is that the case, and could they end up missing with your change? |
|
Debian considers both of them as plugins. So if you need IMAP but not pop you can install just imapd. |
|
OK, so with your change, someone who installs dovecot with this puppet module on Debian will not have either of imap nor pop3 support enabled? That would make for quite a useless configuration, for which enabling either or both should be supported by the module, don't you think? |
|
no, it allows you to control the configuration. If you only need imap you can do If you need both: |
|
What is the status of this pull request? Debian/Ubuntu support is necessary for us, and the diff looks good to me, though perhaps a note about requiring |
I've added in Debian support, keeping it as simple as possible. I also added rspec tests for the existing manifests and the changes I made.