Hey! I noticed you were using setInterval without a proxy.#10
Open
wesalvaro wants to merge 2 commits intotheproductguy:masterfrom
Open
Hey! I noticed you were using setInterval without a proxy.#10wesalvaro wants to merge 2 commits intotheproductguy:masterfrom
wesalvaro wants to merge 2 commits intotheproductguy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I fixed it. This way, your context is preserved. I noticed this because I use jQuery in noConflict mode and the refresh fails as $ is undefined. Using proxy, jQuery will create an anonymous function for you with the call.
It's pretty nice.
I also cleaned up some comparisons and tab/space mixtures.
I really like the plugin! Hope I helped.
-Wes