Simplify data return type and permit inheritance of data over layout and fetch #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rayne
reviewed
Oct 5, 2023
| } | ||
|
|
||
| /** | ||
| * Assign or get template data. |
Contributor
There was a problem hiding this comment.
I would consider to change this documentation to:
Assign or merge with existing template data.
Author
There was a problem hiding this comment.
Yes, should be even :
(Assign|merge with existing) or get template data.
?
| * Fetch a rendered template. | ||
| * @param string $name | ||
| * @param array $data | ||
| * @return string |
Contributor
There was a problem hiding this comment.
$only is not documented. The name should is not yet optimal and clear to me.
Author
There was a problem hiding this comment.
I use the same name variable as twig - see https://twig.symfony.com/doc/3.x/tags/include.html#:~:text=only
Is it enough clear ?
Author
There was a problem hiding this comment.
I did a second commit and rename it $useTemplateData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains 2 propositions without BC break :
template->data()return type (minor)