Add screening to point charge and related quantities and tests#219
Open
marco-2023 wants to merge 14 commits intotheochem:masterfrom
Open
Add screening to point charge and related quantities and tests#219marco-2023 wants to merge 14 commits intotheochem:masterfrom
marco-2023 wants to merge 14 commits intotheochem:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds screening support to point charge integrals and related stress tensor quantities. The changes enable optional basis function screening for performance optimization while maintaining numerical accuracy.
Key changes:
- Added
screen_basisandtol_screenparameters to point charge integral functions - Updated stress tensor evaluation functions to support screening
- Changed default
screen_basisvalue fromTruetoFalseacross multiple integral types for consistency - Enhanced tests to verify screened and non-screened calculations match within tolerance
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gbasis/integrals/point_charge.py | Implemented screening logic for point charge integrals with point masking |
| gbasis/integrals/nuclear_electron_attraction.py | Added screening parameters to nuclear-electron attraction integrals |
| gbasis/evals/stress_tensor.py | Added screening support to stress tensor, Ehrenfest force, and Hessian functions |
| gbasis/integrals/overlap.py | Changed default screen_basis from True to False |
| gbasis/integrals/overlap_asymm.py | Changed default screen_basis from True to False |
| gbasis/integrals/kinetic_energy.py | Changed default screen_basis from True to False |
| gbasis/integrals/momentum.py | Changed default screen_basis from True to False |
| gbasis/integrals/moment.py | Changed default screen_basis from True to False |
| gbasis/integrals/angular_momentum.py | Changed default screen_basis from True to False |
| gbasis/evals/eval.py | Changed default screen_basis from True to False and updated docstrings |
| gbasis/evals/eval_deriv.py | Changed default screen_basis from True to False and updated docstrings |
| gbasis/evals/density.py | Changed default screen_basis from True to False across multiple functions |
| gbasis/evals/electrostatic_potential.py | Added comment explaining no screening for cumulative point charges |
| tests/test_point_charge.py | Added parametrized tests for screening with tolerance checks |
| tests/test_nuclear_electron_attraction.py | Added parametrized tests for screening scenarios |
| tests/test_stress_tensor.py | Enhanced tests with screening parameters and non-screened reference calculations |
| tests/test_density.py | Simplified parametrization to use tuples instead of separate parameters |
| tests/test_angular_momentum.py | Added screening tests and adjusted tolerance for screening accuracy test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Type of Changes
Related