Skip to content

Conversation

@themuffinator
Copy link
Owner

Summary

  • improve gravity-aware spawn validation by normalizing gravity vectors and adjusting drop/clearance traces
  • align ground-support checks with arbitrary gravity axes for safe monster placement
  • add coverage for standard, inverted, and custom gravity spawn scenarios

Testing

  • python tools/ci/run_tests.py (fails: multiple existing test targets do not compile under available standard library; see artifacts/test-results/test-log.txt for details)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +207 to 211
bool CheckSpawnPoint(const Vector3& origin, const Vector3& mins, const Vector3& maxs, Vector3 gravityVector) {
trace_t tr;

if (!mins || !maxs)
return false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Align spawn helper signatures with declarations

CheckSpawnPoint now requires a gravity vector here, but g_local.hpp and existing callers still declare/use the legacy three-parameter version (e.g., g_local.hpp:4577, m_medic.cpp:1046, m_carrier.cpp:314). The old symbol is therefore left undefined at link time and the new overload is never reached, so the game DLL will not build until the header and call sites are updated (the same mismatch exists for the patched FindSpawnPoint/CheckGroundSpawnPoint signatures).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants