Add CI workflow for unit + integration tests on PRs #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from --quiet to --verbose to capture error output in CI - Add --timeout 5 to dalfox args for faster CI runs - Include output in assertion message for debugging CI failures
The headless CI environment doesn't have Chrome installed properly, causing chromedp to panic with 'close of closed channel' error. Skip DOM mining with --skip-mining-dom to avoid this issue while still running the core XSS scan functionality.
--skip-mining-dom wasn't enough; dalfox still uses chromedp for DOM XSS and inJS verification. Use --skip-headless to completely disable headless browser-based scanning that causes the panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_requestevent