Fix state name cannot contains underscore issue#21
Open
fengye wants to merge 2 commits intothefuntastic:masterfrom
Open
Fix state name cannot contains underscore issue#21fengye wants to merge 2 commits intothefuntastic:masterfrom
fengye wants to merge 2 commits intothefuntastic:masterfrom
Conversation
FIxed upstream spelling error
Owner
|
Oh wow, this is from a million years ago, sorry I'm normally good with responding but I see from the timestamp things were crazy at that time. Looks like I good commit. There is a potentially for a Array out of index error though. Will try incorporate this feature next time I'm working on the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for creating the plugin. It works well.
I find the state name cannot contain underscores, otherwise the corresponding state-based function not get called, such as void MY_STATE_IDLE_FixedUpdate(). So I made some changes in the function-finding part, and it now splits the function name with the last underscore it finds.