Conversation
vkrizan
approved these changes
Jul 9, 2025
| @@ -0,0 +1,99 @@ | |||
| # Contains certs specific configurations for IOP | |||
| class certs::iop ( | |||
| Stdlib::Fqdn $hostname = 'localhost', | |||
Member
Author
There was a problem hiding this comment.
Otherwise we have to expose the Gateway on the public interface which I believe we wanted to avoid.
There was a problem hiding this comment.
I was thinking of an alternative, to create a custom name in /etc/hosts for it that would point to local interface.
Member
Author
There was a problem hiding this comment.
What's the value you are thinking?
There was a problem hiding this comment.
No value, just cosmetics. As it would look like a link to something external (that it technically can be). Having a specific name could distinguish other local services, if needed.
Just a suggestion for future. No need to change this.
ehelms
force-pushed
the
add-iop-certs
branch
2 times, most recently
from
deba512 to
5955a9f
Compare
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
evgeni
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add server and client certificates to be used by the IoP Gateway. This does not remove the iop_advisor_engine certificates yet as those should be cleaned up after switching implementation.