Conversation
|
This looks related to #141 but is not an aspect I have incorporated. I was wanting to get in a version of remote database testing and then harden it with more of the options. |
|
It is, @Gauravtalreja1 ran into this when testing ext db stuff |
evgeni
force-pushed
the
ssldb
branch
5 times, most recently
from
f8a1e26 to
1ba7910
Compare
evgeni
force-pushed
the
ssldb
branch
4 times, most recently
from
921e621 to
7355577
Compare
| containers.podman.podman_secret: | ||
| state: present | ||
| name: candlepin-db-ca | ||
| data: "{{ lookup('ansible.builtin.file', candlepin_database_ssl_ca) if candlepin_database_ssl_ca else 'empty' }}" |
There was a problem hiding this comment.
This is creating an empty secret if there is no database SSL cert? Why not use a when conditional on the sercret?
There was a problem hiding this comment.
Because then I need to also conditionally mount it, and that's painful ;)
There was a problem hiding this comment.
I get that, I worry about this being a red herring while debugging.
|
What else do you think is needed to take it out of draft? |
|
I wanted to write up some tests to validate it. |
evgeni
force-pushed
the
ssldb
branch
2 times, most recently
from
46aeafa to
3a61d77
Compare
| - certificate_source: default | ||
| security: none | ||
| database: external | ||
| - certificate_source: default | ||
| security: none | ||
| database: externalssl |
There was a problem hiding this comment.
I personally think that users should never run external db without SSL, but I know that today we document and support that, so I added this as another matrix entry instead of repurposing the external one. But do we really need to test both?
There was a problem hiding this comment.
If you are proposing that we test external database only with TLS - I agree.
There was a problem hiding this comment.
Correct, that's what I wanted to say
evgeni
force-pushed
the
ssldb
branch
7 times, most recently
from
481ca09 to
d157f1a
Compare
evgeni
force-pushed
the
ssldb
branch
2 times, most recently
from
8953b69 to
a0572e5
Compare
|
@ehelms look, no draft! |
2 participants
No description provided.