Rely on smoker for the content tests#266
Conversation
c03eec9 to
a85f3aa
Compare
|
So first the actual change: As expected, it fails because we don't set up DNS for the Vagrant boxes. I didn't port over the ugly hack. But other than that the tests do pass. Then there's another interesting bit that I also spotted locally: This is https://github.com/theforeman/smoker/blob/d2fd3f7cbe3591ebf0d1d1733ffc3edce8a2c36f/tests/test_ping.py#L9-L13 but https://projects.theforeman.org/issues/31545 has long been resolved so I'm not sure why we're seeing it. I've debated using https://gist.github.com/ekohl/e487422d4aaad8ab176c19ec713b700a in the Vagrant setup to have working DNS. @evgeni or others, any thoughts on how we want to proceed here? |
#269 does this and passes. Upside is no hacks, downside is that developers may not have the same environment. |
95ebcb2 to
ad0becd
Compare
This makes sure the domain is set when the management domain is created, which makes libvirt configure dnsmasq as a proper DNS server. This can be used together with systemd-resolved on the host to look up guest IPs. It also configures Vagrant in CI with DNS set up to utilize this.
ad0becd to
c4c840f
Compare
|
I've split off the DNS changes commit into #305 so this commit becomes solely a commit to move tests over to smoker. |
| smoker_url: https://github.com/ekohl/smoker | ||
| smoker_version: add-content-api-tests |
To test out theforeman/smoker#46.