Draft
Conversation
ekohl
reviewed
Jun 30, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'm not sure we need the IPv6 check in a containerized world. It was there partly because of how we configured services in the past (at least Redis, possibly others). I think the new installer can drop it.
Member
|
I think @evgeni and I discussed that we weren't sure if containers would negate this or not. This definitely needs to be tested before we implement the check. We could punt the testing of it to a post 1.0 action. |
Member
|
👍 let's skip this one for now |
Contributor
Author
|
As per the discussion moving this PR to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: #138