Drop scoped_search extensions

[adamruzicka]

It was implemented in scoped_search itself, newer scoped_search will be pulled in by foreman-3.17 (dependency being bumped in theforeman/foreman#10677).

Fixes b2ffab5 (#1083)

Summary by Sourcery

Remove the custom scoped_search autocomplete override and update the Foreman plugin requirement to use scoped_search’s built-in implementation.

Enhancements:

• Drop the ScopedSearch::AutoCompleteBuilder.complete_value_from_db monkey patch now implemented upstream
• Raise the Foreman requirement from 3.13 to 3.17 to pull in the updated scoped_search dependency

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Remove legacy scoped_search extensions now implemented upstream and bump the minimum Foreman version to match newer scoped_search dependency

File-Level Changes

Change	Details	Files
Remove custom scoped_search autocomplete override	Delete ScopedSearch::AutoCompleteBuilder.class_eval block Remove complete_value_from_db override method	lib/foreman_rh_cloud/engine.rb
Update Foreman dependency requirement	Change requires_foreman from '>= 3.13' to '>= 3.17'	lib/foreman_rh_cloud/plugin.rb

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jeremylenz]

What version of the scoped_search gem has the fix?

[adamruzicka]

What version of the scoped_search gem has the fix?

4.3.0

[jeremylenz]

LGTM, though I'd like to wait until the scoped_search fixes are in place before merging

[chris1984]

LGTM, though I'd like to wait until the scoped_search fixes are in place before merging

I see @adamruzicka bumped it to 4.3.0 here wvanbergen/scoped_search@e4f526b and it's on rubygems.org https://rubygems.org/gems/scoped_search/versions/4.3.0 I think we can merge this.

[jeremylenz]

Thanks @adamruzicka!