Merged
Conversation
Contributor
Author
|
@dgoetz could you have a look at it? |
dgoetz
requested changes
May 8, 2025
Member
dgoetz
left a comment
dgoetz
left a comment
There was a problem hiding this comment.
Except for the missing end, does this also effect the minimum ruby version and the minimum Foreman version?
ochnerd
force-pushed
the
feat/zeitwerk_support
branch
from
7fc0420 to
a5dfb20
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
dgoetz
approved these changes
May 8, 2025
Member
|
Thanks @ochnerd, I will directly create a release for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #100