Fixes #39069 - Notifications title is cut by the header#10863
Merged
jeremylenz merged 1 commit intotheforeman:developfrom Feb 10, 2026
Merged
Fixes #39069 - Notifications title is cut by the header#10863jeremylenz merged 1 commit intotheforeman:developfrom
jeremylenz merged 1 commit intotheforeman:developfrom
Conversation
chris1984
reviewed
Feb 10, 2026
Member
chris1984
left a comment
chris1984
left a comment
There was a problem hiding this comment.
Tested and works great, left one style comment
| @@ -269,7 +269,7 @@ def body_css_classes | |||
| end | |||
|
|
|||
| def all_body_css_classes | |||
Member
There was a problem hiding this comment.
Would something like this work to make it more clean:
def all_body_css_classes
classes = body_css_classes
classes += ' compact-ui' if User.current&.ui_compact_mode
classes += ' user-banner-present' if Setting[:instance_title].present?
classes
end
when instance title is set
MariaAga
force-pushed
the
banner-height-to-notifications
branch
from
34e2cb7 to
e7baeca
Compare
chris1984
approved these changes
Feb 10, 2026
Member
chris1984
left a comment
chris1984
left a comment
There was a problem hiding this comment.
ACK, thanks for cleaning it up. @jeremylenz want to take a look?
jeremylenz
approved these changes
Feb 10, 2026
Contributor
jeremylenz
left a comment
jeremylenz
left a comment
There was a problem hiding this comment.
ACK based on @chris1984 testing, thanks @MariaAga!
This was referenced Feb 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when instance title is set.
Made the header and banner vars available more globally and not only for the rails css.
before
after
Updated to check for
Setting[:instance_title].present?as when the setting was emptyForeman.settings.find('instance_title')was returning true.