Fixes #39059 - Update PageLayout to use PF5#10857
Fixes #39059 - Update PageLayout to use PF5#10857adamruzicka merged 1 commit intotheforeman:developfrom
Conversation
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Hi, overall, it looks great. I didn't find any issues. I think we should set the searchBar width to 100% by default and use the toolbarItem widths to set the limitation.
webpack/assets/javascripts/react_app/components/SearchBar/SearchBar.scss
Show resolved
Hide resolved
webpack/assets/javascripts/react_app/routes/common/PageLayout/PageLayout.js
Outdated
Show resolved
Hide resolved
MariaAga
force-pushed
the
pagelayout-pf5
branch
from
c9a6926 to
984e6ea
Compare
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Css file can be replaced by adding alignSelf prop to ToolbarItem
webpack/assets/javascripts/react_app/routes/common/PageLayout/PageLayout.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
| <ToolbarItem id="toolbar-spinner"> | |
| <ToolbarItem id="toolbar-spinner" alignSelf="center"> |
MariaAga
force-pushed
the
pagelayout-pf5
branch
from
984e6ea to
1e83211
Compare
MariaAga
force-pushed
the
pagelayout-pf5
branch
from
1e83211 to
11a807e
Compare
|
rebase so foreman version will be 3.19 in the branch, so the foreman-tasks PR will work with it (it requires foreman version to be set to 3.19) |
adamlazik1
left a comment
adamlazik1
left a comment
There was a problem hiding this comment.
QE ack. Tested on packit. From my testing it doesn't break robottelo.
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
Real acks are in the previous comments, this one is just a formality.
|
Thank you @MariaAga , @Lukshio & @adamlazik1 ! |
4 participants
Visually nothing should change, unless the toolbarButtons are PF3 and there are more than 1 of them, which from what I saw is only the tasks table.
tasks table buttons will get 0 space with this PR, but it will be fixed in a follow up PR in foreman-tasks
PageLayout is used in tasks table, audits list, Filters Form,
RegistrationCommands, UpgradePage and other plugins