Fixes #39056 - Update CounterInput component to PF5

[MariaAga]

WIP as there is an update the vmware page counter usage, #10817 and it might be best to use the wrapper instead. anyway after the vmware page changes this pr should deprecate common/forms/NumericInput.js

The component is defined in webpack/assets/javascripts/react_app/components/common/forms/CounterInput/CounterInput.js

It uses rc-input-number library as it's base. Even though the library seems to be still maintained, it would be better to get rid of one more dependency, especially given that PF5 already has similar capabilities: https://v5-archive.patternfly.org/components/number-input/html

Used in create host -> select compute resource vmware -> virtual machines
create host -> select compute resource libvirt -> virtual machines
discovery_rules/new
and plugins

Tested were generated with AI help

[adamlazik1]

Generally works as expected and looks good. I have few small things to point out.

I'd consider cutting off the decimal part:

But this is not a regression so I will leave that to your judgement.

And maybe units could be added to the warning and error messages too? I see them in the old implementation.

[adamlazik1]

Suggested change

	});
	});

[MariaAga]

thanks! reformatted the test file completely

[MariaAga]

I'd consider cutting off the decimal part:

I think its out of the scope of the PR since the number comes from compute_resource.max_memory.to_i in app/views/compute_resources_vms/form/libvirt/_base.html.erb which is not really the counter input

And maybe units could be added to the warning and error messages too? I see them in the old implementation.

Which ones are missing?
there are:
✓ should display warning message when value exceeds recommendedMaxValue (13 ms)
✓ should display error message when value exceeds max (13 ms)
✓ should prioritize error over warning when both conditions are met (11 ms)
✓ should clear warning when value becomes valid (15 ms)
✓ should clear error when value becomes valid (14 ms)
✓ should not display error or warning when value is within limits (6 ms)

[adamlazik1]

I think its out of the scope of the PR since the number comes from compute_resource.max_memory.to_i in app/views/compute_resources_vms/form/libvirt/_base.html.erb which is not really the counter input

Ack, let's not do that then.

Which ones are missing?

The messages are present, but in the old implementation they contained units like MB as well:

[adamlazik1]

If this is used on the vmware form then I can't quickly access it but I would expect the output to be slightly botched based on #10852 (comment)

[MariaAga]

Updated, thanks!

[MariaAga]

misread unit as unit tests 🤦‍♀️
Added

[adamlazik1]

LGTM.

Tiny nitpick: Would it be possible to create space between the icon and the error message?

[adamlazik1]

No robottelo/airgun tests appear to reference the CounterInput component so I would say this doesn't break robottelo.

[MariaAga]

added space in common/forms/FormField.js

[adamlazik1]

LGTM. Verfied on packit build.