Fixes #38972 - Use FQDN for BMC connection target#10842
Open
sakasusu0919 wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #38972 - Use FQDN for BMC connection target#10842sakasusu0919 wants to merge 1 commit intotheforeman:developfrom
sakasusu0919 wants to merge 1 commit intotheforeman:developfrom
Conversation
ekohl
reviewed
Jan 30, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Not a real review, just something I noticed at first glance.
sakasusu0919
force-pushed
the
fix_38972
branch
2 times, most recently
from
b6b8fa3 to
d44d05e
Compare
When Foreman Web UI configures an FQDN as the BMC target, it now passes that FQDN as the ":host" parameter to Smart Proxy's BMC API requests. Co-Authored-By: Yusuke Hirota <hirota.yusuke@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bug #38972 is caused by the following:
Even though the FQDN is configured in Foreman's BMC interface settings, Foreman invariably specifies the IP address in the :host parameter when using the Smart Proxy BMC API.
This PR fixes this item.
Modifications in this PR
In app/models/nic/bmc.rb, adding :fqdn to args allows the FQDN to be obtained from the models class instance. In app/services/proxy_api/bmc.rb, if an FQDN is set for the BMC interface, it is used as the connection target in preference to the IP address.
As this change also requires updates on the smart-proxy side, we created the following related ticket & PRs:
Ticket
Bug #38973 IP address not retrieved when using SSH API of BMC
PR
#933
All two PRs (one in Foreman and one in smart-proxy) are ready for review.
Your feedback would be greatly appreciated.
Verification Contents: